Castle Paradox

[H-Bomb]

I think my problem is fairly simple.

I scripted a code for facing in 8 directions, it is part of a much larger movement code, but this section has some issues. This is the chunk for turning through the full 8 directions in a clockwise sequence.

[Bob the Hamster]

I'll admit I am really confused as to what exactly this script is supposed to do, however, here is a cleaned-up version of it that uses indentation and removes all the pointless excessive suspendplayer/resumeplayer stuff.

[msw188]

Yeah, my first guess would be to change all of those while's to if's. After that I think we need more. I'm guessing that 'd' is a variable that is assigned the hero's direction, but where and when is it assigned? Also, you could probably save yourself a lot of trouble with a bit of modular arithmetic. The single line:

[TMC]

[H-Bomb]

Sorry to be so shortwinded in the initial post. The script is called by an on keypress script, with a separate endless loop running in the background on the same map.

This script changes allows you to face 8 directions, changing the NPC Image accordingly when you are diagonal (image 6). A part of the script which isn't included here is hitting the up key to advance in the direction you are facing, and the down key to move backwards, or in this case, stop moving.

The entire script runs fine except for the heavy buffer load, and the complete lockup when the key is held down too long.

So yes, it is called on-keypress, the endless loop is a different script, and I just want the right-arrow (CW) to have to be pressed again to execute the next command, and not turn more than 1 click at a time if the button is held. I have a sample RPG file I've slapped together with the corresponding NPCs and complete plotscript code for the movement system, I can post it if need be.

[TMC]

Ok, the first thing to realise is the danger of putting wait statements in an onkeypress script. Do this wrong and the script will be run over and over.

I wrote an article on this: 'Why does my on-keypress script freeze/produce errors when I hold down a key?'

So, assuming that the loop that you have running in the background is not doing anything important and you can pause it without a problem (if this is not the case, you need to rewrite everything), you can use wait commands in an onkeypress script, but you have to stop it from getting called repeatedly.

Your other problem is also solvable. However, in the next version, Ubersetzung, to be released soon, things will change.

Hasta-la-qb+:
-Instead of "key is pressed (key:something)" write "key is pressed (key:something) >= 2". This will be true only if the key has just been pressed this tick.

Ubersetzung/'WIP' builds:
Old games (compiled with a hasta-la-qb plotscr.hsd or earlier) will work as intended.
For new games:
-key is pressed returns 0 or 1 only. Use keyval instead: write "keyval (key:something) >= 2"
-Actually, keyval is the old key is pressed command under a new name.

So you'll have to either use a WIP, or stick to hasta-la-qb

Since you don't want the player to be able to turn continously, you don't need to use while at all.

But wait! One more thing. If you have code that looks like this:

[H-Bomb]

Hi, I changed my script to look more like the last one, it come out looking like this:

[TMC]

Opps, seems the wiki tag escapes forward slashes when it shouldn't. But I really shouldn't be using forward slashes. Here's the link:

http://gilgamesh.dnsalias.org:8080/wiki/ohrrpgce/index.php/Why_does_my_on-keypress_script_freeze/produce_errors_when_I_hold_down_a_key%3F

[Inferior Minion]

[H-Bomb]

it took a while, but I managed to figure the script out, so if anyone was interested, here's how it's done.

[TMC]

Oh, I forgot that keyval interprets key repeat (which starts after a few ticks held down) as new keypresses. Which is probably a nuisance. Just now I couldn't understand why it wasn't working properly for me either until I remembered.

I'm not sure what you mean by a "buffer clearing delay". But I'm surprised that you have script buffer issues with just the background loop and keypress script. That must be a large keypress script. You could split it up in the same way you did the endless loop script.

Script buffer space usage is approximately proportional to the number of commands in your script (like +, if, walkhero), complexity in other words.
The next release (and current WIP builds) don't have a script buffer, so you'll be able to forget about the problem.
_________________
"It is so great it is insanely great."

[H-Bomb]

Hi TMC, what I meant by a buffer clearing delay was a split in the codes being processed, allowing the interpreter to dump what it currently has in the buffer, and load up a new batch. Similar to the science of splitting a large command into several smaller parts.

This is probably a poor way to describe what the wait for key command is doing here, but just what it seemed like at first glance. However, now that I think about it, I think this command is just eliminating any room for error in the timing of the events, I may be wrong about both theories, all I know is that it seems to work.

Good news about the buffer by the way. Now if I'd live to see an end to the 1000 usable only once tag-limit, life couldn't get any sweeter.