Castle Paradox

[gagekilmer]

I'm sure Bob the Hamster and TMC probably hate me by now but Ive got another plotscripting problem, though hopefully my last for a while. I tried to write another script, for a focus system (you can choose balanced, attack, defense, or weapons. all stats being used in your focus are bumped up to 150% all those not being used are brougt down to 50%)

here is my script:

Plotscript, ninattackfocus, begin
variable (who)
who := find hero (hero: kenryoku)
variable (old fire base, new fire max)
old fire base := get hero stat (who, stat:fire, base stat)
new fire max := get hero stat (who, stat:fire, maximum stat)
variable (old water base, new water max)
old water base := get hero stat (who, stat:water, base stat)
new water max := get hero stat (who, stat:water, maximum stat)
variable (old lightning base, new lightning max)
old lightning base := get hero stat (who, stat:lightning, base stat)
new lightning max := get hero stat (who, stat:lightning, maximum stat)
variable (old earth base, new earth max)
old earth base := get hero stat (who, stat:earth, base stat)
new earth max := get hero stat (who, stat:earth, maximum stat)
variable (old wind base, new wind max)
old wind base := get hero stat (who, stat:wind, base stat)
new wind max := get hero stat (who, stat:wind, maximum stat)
variable (old strength base, new strength max)
old strength base := get hero stat (who, stat:strength, base stat)
new strength max := get hero stat (who, stat:strength, maximum stat)
variable (old defense base, new defense max)
old defense base := get hero stat (who, stat:defense, base stat)
new defense max := get hero stat (who, stat:defense, maximum stat)
if (check tag (75)) then
begin
set hero stat (who, stat:fire, ((3 * old fire base) / 2), base stat)
set hero stat (who, stat:water, ((3 * old water base) / 2), base stat)
set hero stat (who, stat:lightning, ((3 * old lightning base) / 2), base stat)
set hero stat (who, stat:earth, ((3 * old earth base) / 2), base stat)
set hero stat (who, stat:wind, ((3 * old wind base) / 2), base stat)
set hero stat (who, stat:strength ((1 * old strength base) / 2), base stat)
set hero stat (who, stat:defense ((1 * old defense base) / 2), base stat)
set hero stat (who, stat:fire, new fire max, current stat)
set hero stat (who, stat:water, new water max, current stat)
set hero stat (who, stat:lightning, new lightning max, current stat)
set hero stat (who, stat:earth, new earth max, current stat)
set hero stat (who, stat:wind, new wind max, current stat)
set hero stat (who, stat:strength, new strength max, current stat)
set hero stat (who, stat:defense, new defense max, current stat)
show text box (137)
wait for text box
set tag (76, on)
set tag (75, off)
end
if (check tag (76)) then
begin
show text box (138)
wait for text box
end
if (check tag (77)) then
begin
set hero stat (who, stat:fire, (2 * old fire base), base stat)
set hero stat (who, stat:water, (2 * old water base), base stat)
set hero stat (who, stat:lightning, (2 * old lightning base), base stat)
set hero stat (who, stat:earth, (2 * old earth base), base stat)
set hero stat (who, stat:wind, (2 * old wind base), base stat)
set hero stat (who, stat:strength, (2 * old strength base), base stat)
set hero stat (who, stat:defense, ((2 * old defense base) / 3), base stat)
set hero stat (who, stat:fire, new fire max, current stat)
set hero stat (who, stat:water, new water max, current stat)
set hero stat (who, stat:lightning, new lightning max, current stat)
set hero stat (who, stat:earth, new earth max, current stat)
set hero stat (who, stat:wind, new wind max, current stat)
set hero stat (who, stat:strength, new strength max, current stat)
set hero stat (who, stat:defense, new defense max, current stat)
set hero stat (who, stat:fire, ((3 * old fire base) / 2), base stat)
set hero stat (who, stat:water, ((3 * old water base) / 2), base stat)
set hero stat (who, stat:lightning, ((3 * old lightning base) / 2), base stat)
set hero stat (who, stat:earth, ((3 * old earth base) / 2), base stat)
set hero stat (who, stat:wind, ((3 * old wind base) / 2), base stat)
set hero stat (who, stat:strength ((1 * old strength base) / 2), base stat)
set hero stat (who, stat:defense ((1 * old defense base) / 2), base stat)
set hero stat (who, stat:fire, new fire max, current stat)
set hero stat (who, stat:water, new water max, current stat)
set hero stat (who, stat:lightning, new lightning max, current stat)
set hero stat (who, stat:earth, new earth max, current stat)
set hero stat (who, stat:wind, new wind max, current stat)
set hero stat (who, stat:strength, new strength max, current stat)
set hero stat (who, stat:defense, new defense max, current stat)
show text box (137)
wait for text box
set tag (76, on)
set tag (77, off)
end
if (check tag (7) then
begin
set hero stat (who, stat:fire, (2 * old fire base), base stat)
set hero stat (who, stat:water, (2 * old water base), base stat)
set hero stat (who, stat:lightning, (2 * old lightning base), base stat)
set hero stat (who, stat:earth, (2 * old earth base), base stat)
set hero stat (who, stat:wind, (2 * old wind base), base stat)
set hero stat (who, stat:strength, ((2 * old strength base) / 3), base stat)
set hero stat (who, stat:defense, (2 * old defense base), base stat)
set hero stat (who, stat:fire, new fire max, current stat)
set hero stat (who, stat:water, new water max, current stat)
set hero stat (who, stat:lightning, new lightning max, current stat)
set hero stat (who, stat:earth, new earth max, current stat)
set hero stat (who, stat:wind, new wind max, current stat)
set hero stat (who, stat:strength, new strength max, current stat)
set hero stat (who, stat:defense, new defense max, current stat)
set hero stat (who, stat:fire, ((3 * old fire base) / 2), base stat)
set hero stat (who, stat:water, ((3 * old water base) / 2), base stat)
set hero stat (who, stat:lightning, ((3 * old lightning base) / 2), base stat)
set hero stat (who, stat:earth, ((3 * old earth base) / 2), base stat)
set hero stat (who, stat:wind, ((3 * old wind base) / 2), base stat)
set hero stat (who, stat:strength ((1 * old strength base) / 2), base stat)
set hero stat (who, stat:defense ((1 * old defense base) / 2), base stat)
set hero stat (who, stat:fire, new fire max, current stat)
set hero stat (who, stat:water, new water max, current stat)
set hero stat (who, stat:lightning, new lightning max, current stat)
set hero stat (who, stat:earth, new earth max, current stat)
set hero stat (who, stat:wind, new wind max, current stat)
set hero stat (who, stat:strength, new strength max, current stat)
set hero stat (who, stat:defense, new defense max, current stat)
show text box (137)
wait for text box
set tag (76, on)
set tag (78, off)
end
end

two issues
1. you start with tag 75 (balanced) on, and when you switch to using attack (tag 76 on) the stats in the status menu dont change.
2. after turning tag 76 on, i made it so trying to turn it on again will show you text box 138, instead of 137. 137 is still showing

any ideas?

[GozerGomez]

I notice you're changing the base stat instead of the maximum stat. Maybe that's causing #1. According to the plotscripting dictionary,
http://hamsterrepublic.com/ohrrpgce/docs/plotdict.xml#about-basestat , changes to the base stat *don't* appear on the menus by default.

It's hard to guess what the problem is. Hit F4 to open the Tag Debug menu, and use the PageDown button to go down to 75, 76, 77 and 78. Are they all the same color? If I read this script correctly, and I think I do, you're going to have to get 75, 77 and 78 turned off before it'll show something that isn't 137. Look at the flow of the script.

You ask at the start.. "Is Tag 75 on? If so, turn Tag 76 on and turn Tag 75 off."

But then you immediately ask "Is Tag 76 on? If so, do this" so any time Tag 75 was on and the script is called, you're going to do the 76 part, because 75 turned on 76.

Later on, you ask "Is 77 on? If so, turn 77 off and then turn on 76", but you don't do anything to 75. Likewise, for 78, you don't do anything about 77. You might want to and some ands to this thing, for instance...

[GozerGomez]

Oh! and my programmer suggests you might want to move the "If checktag (76)" bit to as close to the end as possible, so the 77 and 78 blocks could trigger it in the same breath, and not just the 75. You might also want to make say, turning 75 on automatically turn off 77 and 78, and turning 77 on makes turn 75 and 78, and turning 78 on makes 77 and 75 go out, so that the styles are somewhat exclusive. Again, it's hard to tell what you're trying to do, I'm sorry. Some screenshots or a diagram or something might make it clearer.

[gagekilmer]

I think I realized what I did wrong, I however do not know how to fix it.
the "if (check tag(**)) commands are supposed to check what "mode" you are in. so if it returns false (not meeting the criteria) then its supposed to move on to the next check tag and see if it fits the criteria... and i fixed the issue with the stat not changing, I think. is there and else command to continue the script, and skip the "begin" to the "end" I dont know if that made any sense at all...

[gagekilmer]

disregard my last post.

this is the edited script:

Plotscript, ninattackfocus, begin
variable (who)
who := find hero (hero: kenryoku)
variable (new fire max)
new fire max := get hero stat (who, stat:fire, maximum stat)
variable (new water max)
new water max := get hero stat (who, stat:water, maximum stat)
variable (new lightning max)
new lightning max := get hero stat (who, stat:lightning, maximum stat)
variable (new earth max)
new earth max := get hero stat (who, stat:earth, maximum stat)
variable (new wind max)
new wind max := get hero stat (who, stat:wind, maximum stat)
variable (new strength max)
new strength max := get hero stat (who, stat:strength, maximum stat)
variable (new defense max)
new defense max := get hero stat (who, stat:defense, maximum stat)
if (check tag (75) == on, and, check tag(76) == off, and, check tag (77) == off, and, check tag (7 ==off) then
begin
set hero stat (who, stat:fire, ((3 * new fire max) / 2), maximum stat)
set hero stat (who, stat:water, ((3 * new water max) / 2), maximum stat)
set hero stat (who, stat:lightning, ((3 * new lightning max) / 2), maximum stat)
set hero stat (who, stat:earth, ((3 * new earth max) / 2), maximum stat)
set hero stat (who, stat:wind, ((3 * new wind max) / 2), maximum stat)
set hero stat (who, stat:strength ((1 * new strength max) / 2), maximum stat)
set hero stat (who, stat:defense ((1 * new defense max) / 2), maximum stat)
set hero stat (who, stat:fire, maximum stat, current stat)
set hero stat (who, stat:water, maximum stat, current stat)
set hero stat (who, stat:lightning, maximum stat, current stat)
set hero stat (who, stat:earth, maximum stat, current stat)
set hero stat (who, stat:wind, maximum stat, current stat)
set hero stat (who, stat:strength, maximum stat, current stat)
set hero stat (who, stat:defense, maximum stat, current stat)
show text box (137)
wait for text box
set tag (76, on)
set tag (75, off)
end
if (check tag (76)) then
begin
show text box (138)
wait for text box
end
if (check tag (77)) then
begin
set hero stat (who, stat:fire, (2 * new fire max), maximum stat)
set hero stat (who, stat:water, (2 * new water max), maximum stat)
set hero stat (who, stat:lightning, (2 * new lightning max), maximum stat)
set hero stat (who, stat:earth, (2 * new earth max), maximum stat)
set hero stat (who, stat:wind, (2 * new wind max), maximum stat)
set hero stat (who, stat:strength, (2 * new strength max), maximum stat)
set hero stat (who, stat:defense, ((2 * new defense max) / 3), maximum stat)
set hero stat (who, stat:fire, maximum stat, current stat)
set hero stat (who, stat:water, maximum stat, current stat)
set hero stat (who, stat:lightning, maximum stat, current stat)
set hero stat (who, stat:earth, maximum stat, current stat)
set hero stat (who, stat:wind, maximum stat, current stat)
set hero stat (who, stat:strength, maximum stat, current stat)
set hero stat (who, stat:defense, maximum stat, current stat)
set hero stat (who, stat:fire, ((3 * new fire max) / 2), maximum stat)
set hero stat (who, stat:water, ((3 * new water max) / 2), maximum stat)
set hero stat (who, stat:lightning, ((3 * new lightning max) / 2), maximum stat)
set hero stat (who, stat:earth, ((3 * new earth max) / 2), maximum stat)
set hero stat (who, stat:wind, ((3 * new wind max) / 2), maximum stat)
set hero stat (who, stat:strength ((1 * new strength max) / 2), maximum stat)
set hero stat (who, stat:defense ((1 * new defense max) / 2), maximum stat)
set hero stat (who, stat:fire, maximum stat, current stat)
set hero stat (who, stat:water, maximum stat, current stat)
set hero stat (who, stat:lightning, maximum stat, current stat)
set hero stat (who, stat:earth, maximum stat, current stat)
set hero stat (who, stat:wind, maximum stat, current stat)
set hero stat (who, stat:strength, maximum stat, current stat)
set hero stat (who, stat:defense, maximum stat, current stat)
show text box (137)
wait for text box
set tag (76, on)
set tag (77, off)
end
if (check tag (7) then
begin
set hero stat (who, stat:fire, (2 * new fire max), maximum stat)
set hero stat (who, stat:water, (2 * new water max), maximum stat)
set hero stat (who, stat:lightning, (2 * new lightning max), maximum stat)
set hero stat (who, stat:earth, (2 * new earth max), maximum stat)
set hero stat (who, stat:wind, (2 * new wind max), maximum stat)
set hero stat (who, stat:strength, ((2 * new strength max) / 3), maximum stat)
set hero stat (who, stat:defense, (2 * new defense max), maximum stat)
set hero stat (who, stat:fire, maximum stat, current stat)
set hero stat (who, stat:water, maximum stat, current stat)
set hero stat (who, stat:lightning, maximum stat, current stat)
set hero stat (who, stat:earth, maximum stat, current stat)
set hero stat (who, stat:wind, maximum stat, current stat)
set hero stat (who, stat:strength, maximum stat, current stat)
set hero stat (who, stat:defense, maximum stat, current stat)
set hero stat (who, stat:fire, ((3 * new fire max) / 2), maximum stat)
set hero stat (who, stat:water, ((3 * new water max) / 2), maximum stat)
set hero stat (who, stat:lightning, ((3 * new lightning max) / 2), maximum stat)
set hero stat (who, stat:earth, ((3 * new earth max) / 2), maximum stat)
set hero stat (who, stat:wind, ((3 * new wind max) / 2), maximum stat)
set hero stat (who, stat:strength ((1 * new strength max) / 2), maximum stat)
set hero stat (who, stat:defense ((1 * new defense max) / 2), maximum stat)
set hero stat (who, stat:fire, maximum stat, current stat)
set hero stat (who, stat:water, maximum stat, current stat)
set hero stat (who, stat:lightning, maximum stat, current stat)
set hero stat (who, stat:earth, maximum stat, current stat)
set hero stat (who, stat:wind, maximum stat, current stat)
set hero stat (who, stat:strength, maximum stat, current stat)
set hero stat (who, stat:defense, maximum stat, current stat)
show text box (137)
wait for text box
set tag (76, on)
set tag (78, off)
end
end


if it meets the check tag criteria, it will go through the smaller scripts (begin to end) which end with turning tags on and off. if these tags are changed the script needs to end, it can only continue if it doesnt meet the check tag criteria, in which case it moves down to the next check tag, same situation there, if it runs the smaller script it needs to end there

[G. Gomez]

I don't believe that's the case. Even if the conditional answers false, it will still continue to the next conditional and so on, until it reaches the end of the script. If you want it to end when one of the settings has changed, you should probably break this down into smaller scripts and take a look at the ExitScript command.

[sotrain515]

Hello, I have some advice. First, please use the "Code" tags to post your plotscripting samples onto the forums, it makes it so much easier to read. I think you lose tab-indentation out of hand (at least I seem to on Firefox), but spaces will stay. Which brings me to my next advice: please indent your code so that the blocks are more visible. I went ahead and applied these to your second code snippet:

[gagekilmer]

The mega post was helpful, however this is why nobody understood what I was trying to do. there are four scripts like this one. there is a menu called "Ninja Focus" with four menu items. Jutsu - fire, water, wind, earth, lightning boosted defense and strength lowered. Defense - Defense augmented everything else diminished. Strength - Strength is augmented everything else is diminished. and Balanced. all at normal values. This script runs whenyou choose the Jutsu focus. that is why all of the mini scripts turn tag 76 on, that is the tag saying that that is the mode you are in. tag 75 - in balanced mode
tag 77 - defense. tag 78 - strength.
I moved the already in tag 76 script near the top so a small problem was fixed. you pointing out to use find hero stat (who, stat:x, maximum stat) instead of just maximum stat solved my problem.
in code snippet 2, you are in defensive mode, meaning that the other script already halved the fire stat. so we are doubling it to return it to normal value and then multiplying by 3/2 to bring it up to 150%. thats what confused everyone

[sotrain515]

[gagekilmer]

thanks a ton, now all I have to do is write this 11 more times

[sotrain515]

You're welcome. May I ask why you have to write it 11 more times?

[gagekilmer]

because there are 3 characters, each with 4 modes. for a total of 12 scripts. I completed one of them, well at this point 4 of them, and they all work now that I know what I did wrong

[BMR]

Spreadsheet it. Easy way to make multiple sets of code.

Alternatively, rewrite this to be able to accept different characters/modes. You could then pass the hero number to this, and it'll set everything depending on the hero number passed. That way you won't have to have multiple sets of code that all do the same thing.
_________________
Being from the third world, I reserve the right to speak in the third person.

[sotrain515]

Yes, and please allow me to elaborate on BMR's alternative suggestion to have your existing code apply to multiple characters...

Let's take your original script's beginning couple of lines (this is based on my revision):

[TMC]

I haven't read through this thread, but I'd just like to point out that "ninattackfocus(hero:kenryoku)" should be "ninattackfocus(findhero(hero:kenryoku))"
_________________
"It is so great it is insanely great."